Vil 83 #992
Merged
Vil 83 #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Created the first 3 statistics cards of the "En famille" part in the Village Dashboard.
The first filter asks you to select a country, while the second asks you to select a village from that given country.
Changes
Modified the village controller so that he can accept a query string
?countryIsoCode=Xfor example.The useVillage hook has also been modified in that way.
The VillageStats component now renders for a given village :
I created 3 queries in
server/stats/villageStats.tsin order to fill those cards.Brief review on the stylesheets for the statistics part + responsive.
Test
As an admin user, you can visit the "Analyser" tab. Then navigate to "Village-monde" et select "En famille". You should see the correct statistics. You may need to create a teacher and some students if you've not already done it in your local environment.